Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): add vue-router to optimized deps #8544

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#15288

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It seems that we could end up with multiple versions of vue-router when optimising dependencies, and therefore have mismatching route symbols.

This PR ensures that when using the pages integration we process the router first.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 28, 2022
@danielroe danielroe requested a review from pi0 October 28, 2022 03:28
@danielroe danielroe self-assigned this Oct 28, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 28, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 28, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 91670a5
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/635b4c7cb1027100083297fa

@pi0 pi0 merged commit 28ffb7f into main Nov 2, 2022
@pi0 pi0 deleted the fix/optimize-router branch November 2, 2022 08:53
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

injection "Symbol(route location)" not found
2 participants